[
https://issues.apache.org/jira/browse/IGNITE-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643364#comment-15643364
]
Alexey Kuznetsov edited comment on IGNITE-3066 at 11/7/16 7:20 AM:
-------------------------------------------------------------------
Roman, see my first comments:
# In modules\clients\pom.xml new dependency "redis.clients.jedis" should be
<scope>test</scope>.
# Please revert changes in javadocs in {{IgniteConfiguration}} &
{{GridKernalContext}}, they are not related to this issue.
# {{GridRedisGenericException}} & {{GridRedisTypeException}} - ASF header
missing.
# {{GridClientPacketType}} - may be it will be better to have {{REDIS}} instead
of {{RESP}}?
# {{RedisProtocolSelfTest}} move {{private static final int GRID_CNT = 1}}
constant to the class top. Also this constant is "1".
What about multi nodes tests?
# {{GridRedisGenericException}} - how about to introduce several descendants?
Like {{GridRedisIllegalArgumentException}}?
# {{GridRedisTypeException }}- declared, but I not found any {{throw new
GridRedisTypeException}}
# There a lot of duplicated code in
{{GridRedisXXXCommandHandler.asRestRequest()}} methods - could this be somehow
generalized in parent class?
For example: {{GridRedisDelCommandHandler}} and
{{GridRedisExistsCommandHandler}}.
I will do one more review after you will address my comments.
was (Author: kuaw26):
Roman, see my first comments:
# In modules\clients\pom.xml new dependency "redis.clients.jedis" should be
<scope>test</scope>.
# Please revert changes in javadocs in {{IgniteConfiguration}} &
{{GridKernalContext}}, they are not related to this issue.
# {{GridRedisGenericException}} & {{GridRedisTypeException}} - ASF header
missing.
# {{GridClientPacketType}} - may be it will be better to have {{REDIS}} instead
of {{RESP}}?
# {{RedisProtocolSelfTest}} move {{private static final int GRID_CNT = 1}}
constant to the class top. Also this constant is "1".
What about multi nodes tests?
# {{GridRedisGenericException}} - how about to introduce several descendants?
Like {{GridRedisIllegalArgumentException}}?
# {{GridRedisTypeException }}- declared, but I not found any {{throw new
GridRedisTypeException}}
# There a lot of duplicated code in
{{GridRedisXXXCommandHandler.asRestRequest()}} methods - could this be somehow
generalized in parent class?
For example: {{GridRedisDelCommandHandler}} and
{{GridRedisExistsCommandHandler}}.
I will do one more review after
> Set of Redis commands that can be easily implemented via existing REST
> commands
> -------------------------------------------------------------------------------
>
> Key: IGNITE-3066
> URL: https://issues.apache.org/jira/browse/IGNITE-3066
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
>
> As the 1st iteration of IGNITE-2788 the following commands can be implemented
> via existing REST commands,
> GET
> MGET
> SET
> MSET
> INCR
> DECR
> INCRBY
> DECRBY
> APPEND
> STRLEN
> GETSET
> SETRANGE
> GETRANGE
> DEL
> EXISTS
> DBSIZE
> http://redis.io/commands
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
