[
https://issues.apache.org/jira/browse/IGNITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667076#comment-15667076
]
Semen Boikov edited comment on IGNITE-3075 at 11/15/16 1:05 PM:
----------------------------------------------------------------
Hi,
Reviewed changes, have some comments:
- please remove forceTransformBackups GridDhtAtomicSingleUpdateRequest (this is
not supported now and anyway remember that boolean fields should be passed as
part of 'flags')
- in 'GridDhtAtomicSingleUpdateFuture.canUseSingleRequest' you also need check
that cache does not have default expiry policy (ctx.expiry() == null). Also you
do not pass 'conflict' fields in single request, how do you guarantee single
request is not created if there are 'conflict' values?
- there are failures on TC, at least in Expiry Policy suite, please make sure
all is fixed before next review
Thanks!
was (Author: sboikov):
Hi,
Reviewed changes, have some comments:
- please remove forceTransformBackups GridDhtAtomicSingleUpdateRequest (this is
not supported now and anyway remember that boolean fields should be passed as
part of 'flags')
- in 'GridDhtAtomicSingleUpdateFuture.canUseSingleRequest' you also need check
that cache does not have default expiry policy (ctx.expiry() == null)
- there are failures on TC, at least in Expiry Policy suite, please make sure
all is fixed before next review
Thanks!
> Implement single key-value pair DHT request/response for ATOMIC cache.
> ----------------------------------------------------------------------
>
> Key: IGNITE-3075
> URL: https://issues.apache.org/jira/browse/IGNITE-3075
> Project: Ignite
> Issue Type: Task
> Components: cache
> Affects Versions: 1.5.0.final
> Reporter: Vladimir Ozerov
> Assignee: Konstantin Dudkov
> Labels: performance
> Fix For: 1.8
>
>
> Need to implement specialized light-weight version of DHT request/response to
> make the most common case - single KV update - more performant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
