[ 
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670037#comment-15670037
 ] 

Anton Vinogradov commented on IGNITE-3303:
------------------------------------------

Saikat, 

1) As far as I can see 
{noformat}
stopped = true;
{noformat}
at {{org.apache.ignite.source.flink.IgniteSource#stop}} has no impact on
{noformat}
while (!stopped) {
...
{notofmat}
at {{org.apache.ignite.source.flink.IgniteSource#run}}. You can check that 
{{while}} will contiue to work.
This happens because these are different {{stopped}} fields, because they are 
inside different {{IgniteSource}} instances.

Seems that {{IgniteSource}} added as a source to {{StreamExecutionEnvironment}} 
is used just like template, so there is no way to manage it externally (from 
test).
I think that {{org.apache.ignite.source.flink.IgniteSource#cancel}} is the 
correct way to stop {{IgniteSource}}, but it should be triggered from 
{{StreamExecutionEnvironment}}, somehow.
So, we should get rid of {{org.apache.ignite.source.flink.IgniteSource#stop}} 
and relocate it's content to 
{{org.apache.ignite.source.flink.IgniteSource#cancel}}.

Am I missed something?

2) Anyway, we have to check that we can use more than one {{IgniteSource}} 
together.
Also, in case {{parallelism}} > 1 can be a good case for production we should 
test this case as well.

> Apache Flink Integration - Flink source to run a continuous query against one 
> or multiple caches
> ------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-3303
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3303
>             Project: Ignite
>          Issue Type: New Feature
>          Components: streaming
>            Reporter: Saikat Maitra
>            Assignee: Saikat Maitra
>         Attachments: Screen Shot 2016-10-07 at 12.44.47 AM.png, 
> testFlinkIgniteSourceWithLargeBatch.log, win7.PNG
>
>
> Apache Flink integration 
> +++ *Ignite as a bidirectional Connector* +++
> As a Flink source => run a continuous query against one or multiple
> caches [4].
> Related discussion : 
> http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Flink-lt-gt-Apache-Ignite-integration-td8163.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to