[ https://issues.apache.org/jira/browse/IGNITE-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716945#comment-15716945 ]
Valentin Kulichenko commented on IGNITE-4140: --------------------------------------------- The ticket is scheduled for 2.0, so we can just change the API. Regarding the code I have only these minor comments: * You removed the license header from {{KafkaStreamer}}. Please bring it back. * Why did you use explicit check instead of {{A.ensure}} and {{log.error}} instead of {{U.error}}? This is against guidelines, so please revert. * We are using spaces instead of tabs for indentation. Please fix these and we will merge your contribution. > KafkaStreamer should use tuple extractor instead of decoders > ------------------------------------------------------------ > > Key: IGNITE-4140 > URL: https://issues.apache.org/jira/browse/IGNITE-4140 > Project: Ignite > Issue Type: Improvement > Components: streaming > Affects Versions: 1.7 > Reporter: Valentin Kulichenko > Assignee: Anil > Labels: patch-available > Fix For: 2.0 > > > Current design of {{KafkaStreamer}} looks incorrect to me. In particular, it > extends {{StreamAdapter}}, but ignores tuple extractors provided there and > uses native Kafka decoders instead. This for example makes impossible to > produce several entries from one message, like it can be done via > {{StreamMultipleTupleExtractor}} in other streamers. > To fix this, we should: > # Declare the {{KafkaStreamer}} like this: > {code} > KafkaStreamer<K, V> extends StreamAdapter<MessageAndMetadata<byte[], byte[]>, > K, V> > {code} > # Remove {{keyDecoder}} and {{valDecoder}} in favor of tuple extractors. > # Instead of doing {{getStreamer().addData(...)}} directly, call > {{addMessage(...)}} method providing the raw message consumed from Kafka > ({{MessageAndMetadata<byte[], byte[]>}}). This method will make sure that > configured extractor is invoked and that all entries are added to > {{IgniteDataStreamer}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)