[
https://issues.apache.org/jira/browse/IGNITE-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767535#comment-15767535
]
ASF GitHub Bot commented on IGNITE-4142:
----------------------------------------
GitHub user AMashenkov opened a pull request:
https://github.com/apache/ignite/pull/1372
IGNITE-4142: Assertion in ClientImpl.updateMetrics()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-4142-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1372.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1372
----
commit 6319c3b9e6a187157435ecf848dc0d82717484cb
Author: Andrey V. Mashenkov <[email protected]>
Date: 2016-12-21T16:53:08Z
Fixed.
----
> Assertion in ClientImpl.updateMetrics()
> ---------------------------------------
>
> Key: IGNITE-4142
> URL: https://issues.apache.org/jira/browse/IGNITE-4142
> Project: Ignite
> Issue Type: Bug
> Components: general
> Affects Versions: 1.7
> Reporter: Valentin Kulichenko
> Assignee: Andrew Mashenkov
> Priority: Critical
> Fix For: 2.0
>
>
> The problem was reported here:
> http://apache-ignite-users.70518.x6.nabble.com/AssertionError-td8321.html
> It looks like the reason is that
> {{TcpDiscoveryHeartbeatMessage.setCacheMetrics()}} method does not put empty
> map in the {{cacheMetrics}} collection. As a result, it's possible that there
> are cluster metrics for a node, but no cache metrics for this node - this
> leads to the assertion in {{ClientImpl.updateMetrics}} (see below). We should
> remove the {{if}} in {{TcpDiscoveryHeartbeatMessage.setCacheMetrics()}} or
> change {{ClientImpl.updateMetrics}} logic so that it does not fail in this
> case.
> We should also try to reproduce in a unit test to make sure this the only
> problematic code here.
> {noformat}
> 10:39:38,355 SEVERE [TcpDiscoverySpi] Runtime error caught during grid
> runnable execution: IgniteSpiThread
> [name=tcp-client-disco-msg-worker-#4%FooGrid%]: java.lang.AssertionError
> at
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.updateMetrics(ClientImpl.java:2046)
>
> at
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processHeartbeatMessage(ClientImpl.java:1926)
>
> at
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processDiscoveryMessage(ClientImpl.java:1580)
>
> at
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.body(ClientImpl.java:1499)
>
> at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
