[
https://issues.apache.org/jira/browse/IGNITE-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816407#comment-15816407
]
Aliaksandr Kazlou commented on IGNITE-4530:
-------------------------------------------
Hi, [~dmagda] I will take a look and address them tomorrow. I also think have
to put `testIpFinder` in every of the test class (I think the one from the
abstract parent will not be picked, see below). Also I have not tested it yet,
expected there to be some CI which will fail if there is an issue. Will then
test it manually as well, and after will move into "patch available" state if
everything works and comments addressed.
> Passing AWSCredentialsProvider to TcpDiscoveryS3IpFinder
> --------------------------------------------------------
>
> Key: IGNITE-4530
> URL: https://issues.apache.org/jira/browse/IGNITE-4530
> Project: Ignite
> Issue Type: Bug
> Reporter: Denis Magda
> Assignee: Aliaksandr Kazlou
>
> {{TcpDiscoveryS3IpFinder}} accepts credentials in a form of
> {{AWSCredentials}} only. This might not be enough for all the cases. In a
> situation when the credentials get expired a special instance of
> {{AWSCredentialsProvider}} can renew them automatically.
> However, the credentials will not be updated if {{StaticCredentialsProvider}}
> is used. This provider is created automatically if user provides raw
> {{AWSCredentials}}.
> We need to add new method to {{TcpDiscoveryS3IpFinder}} that will accept
> {{AWSCredentialsProvider}}:
> {code}
> public void setAwsCredentialsProvider(AWSCredentialsProvider provider) {
> {code}
> A new test has to be added to {{TcpDiscoveryS3IpFinderSelfTest}} as well.
> For more details refer to a discussion on the user list:
> http://apache-ignite-users.70518.x6.nabble.com/Old-AWS-SDK-version-why-td9824.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
