[
https://issues.apache.org/jira/browse/IGNITE-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833113#comment-15833113
]
ASF GitHub Bot commented on IGNITE-4564:
----------------------------------------
GitHub user AMashenkov opened a pull request:
https://github.com/apache/ignite/pull/1449
IGNITE-4564: Ensure that builder approach is used for all setters in public
API
Configurations support chainging setters.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-4564
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1449.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1449
----
commit 3ae84e40b453d5d7a91c490d1e11fb0213a78efd
Author: AMRepo <[email protected]>
Date: 2017-01-21T19:13:55Z
Public Configurations fixed.
commit 2b8be734d7ff19ed61c3fe7a0c5d8c544b49af22
Author: AMRepo <[email protected]>
Date: 2017-01-21T19:14:15Z
Internal Configurations fixed.
----
> Ensure that builder approach is used for all setters in public API
> ------------------------------------------------------------------
>
> Key: IGNITE-4564
> URL: https://issues.apache.org/jira/browse/IGNITE-4564
> Project: Ignite
> Issue Type: Task
> Components: general
> Affects Versions: 1.8
> Reporter: Vladimir Ozerov
> Assignee: Andrew Mashenkov
> Fix For: 2.0
>
>
> *Problem*
> We employed "builder" approach for some configuration classes:
> {code}
> class Configuration {
> Configuration setSomething(Something);
> }
> {code}
> This is very convenient for users. However, only part of our configs employ
> this approach.
> *Task*
> Let's make sure that all other parts of our API follow this rule.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
