[jira] (IGNITE-4538) BinaryObjectImpl: lack of context information upon deserialization

[Vladimir Ozerov (JIRA)]

Title: Message Title

Vladimir Ozerov assigned an issue to Alexandr Kuramshin   Alexander, my comments: 1) Changes to IgniteCacheProxy, GridCacheAdapter and GridCacheQueryManager looks invalid to me. Why do we need to change exception handling logic in these places? As far as I understand, all changes must be inside binary package only. Moreover, we have a convention, that internal components talk to each other through checked exceptions, this is why we do not catch RuntimeException there. 2) GridBinaryMarshaller.typeName - we already have such mapping in BinaryUtils. All you need is to create reverse map there. 3) Remember that in addition to type ID flags we may have other special flags, e.g. handles and null value. Make sure that you print them correctly as well. 4) Change in BinaryClassDescriptor should be moved to BinaryFieldAccessor. Otherwise it breaks encapsulation. 5) The same goes for changes in BinaryReaderExImpl.deserialize0 - they should reside in BinaryClassDescriptor. 6) You completely ignored Binarylizable case, when you defines serialization logic manually and there are no BinaryFieldAccessor at all. Apparently, you should add exception proper try-catch blocks to all BinaryReaderExImpl.read*(String fieldName) methods. Ignite / IGNITE-4538 BinaryObjectImpl: lack of context information upon deserialization Change By: Vladimir Ozerov Assignee: Vladimir Ozerov Alexandr Kuramshin Status: Patch Available Open Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)