[ 
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849518#comment-15849518
 ] 

Alexey Kuznetsov commented on IGNITE-3625:
------------------------------------------

Taras, in general looks good for me, but when I started some my tests I got 
following exception:
{code}
Cache name cannot match the template "igfs-<igfs_name>(-data|-meta)" because it 
is reserved for IGFS internal purposes.
{code}
And I have no idea what cache has wrong name. How about to print actual cache 
name in order user to be able quickly found wrong name and fix it?
The exception message could look like this:
{code}
Cache name 'zzzz' cannot match the template "igfs-<igfs_name>(-data|-meta)" 
because it is reserved for IGFS internal purposes.
{code}


> IGFS: Use common naming for IGFS meta and data caches.
> ------------------------------------------------------
>
>                 Key: IGNITE-3625
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3625
>             Project: Ignite
>          Issue Type: Task
>          Components: IGFS
>    Affects Versions: 1.6
>            Reporter: Vladimir Ozerov
>            Assignee: Alexey Kuznetsov
>             Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data. 
> See {{FileSystemConfiguration.metaCacheName}} and 
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the 
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es, 
> or if it is configured as both meta and data cache for a single IGFS, then 
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to 
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed 
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should 
> be thrown. The most simple way: throw an exception if user-configured cache 
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to