[ 
https://issues.apache.org/jira/browse/IGNITE-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861846#comment-15861846
 ] 

Denis Magda commented on IGNITE-4212:
-------------------------------------

[~oleg-ostanin], great, finally I could execute the benchmarks. Awesome 
contribution!

A couple of comments so far to make it even better:

* I suggest creating and using "remote" alternatives of configs for "Running 
Ignite Benchmarks Remotely" section. Please take the newly attached README and 
copy it to your branch. Also, copy these new files, attached to the ticket, to 
the "config" directory of "benchmarks/config" and "benchmarks/source/config" 
foldes:
- benchmark-remote-sample.properties
- benchmark-remote.properties
- ignite-remote-config.xml
Refer to updated "Running Ignite Benchmarks Remotely" to find out why they are 
needed.

* Auto-generate "benchmarks/output" directory during benchmarks execution and 
put "results-{DATE-TIME}" and "logs-{DATE-TIME}" there. The README has been 
already updated to reflect this.

* Presently garbage collection logs are added under "benchmarks" directory. Put 
them under "benchmarks/output" under their own "gc-{DATE-TIME}" folder. 

* The graphs are not generated at the end of benchmarks execution. Only a 
couple of CSV files are added into "results-{DATE-TIME}". Could you add the 
graphs as well?

* Please replace the content of DEVNOTES with the content of the file attached.

* If to create an IntellijIDEA project from the sources you will not be able to 
compile {{IgniteNode}} class because of the two lines below

{code}

                cc.setReadThrough(args.isStoreEnabled());

                cc.setWriteThrough(args.isStoreEnabled());
{code}

[~skozlov], this is all from my side. Once the issues are addressed please 
validate the benchmarks on QA side trying to use them for 1.9 benchmarking 
purposes.

> Ignite Benchmarking Simplification and Automation
> -------------------------------------------------
>
>                 Key: IGNITE-4212
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4212
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Denis Magda
>            Assignee: Oleg Ostanin
>             Fix For: 1.9
>
>         Attachments: benchmark-remote.properties, 
> benchmark-remote-sample.properties, DEVNOTES.txt, ignite-remote-config.xml, 
> README.txt
>
>
> There is a plenty of useful Yardstick benchmarks located in ignite-yardstick 
> module that is used by the community to check Ignite performance across 
> deployments of different configurations.
> However, it's not easy to start with the benchmarking process because the 
> user needs to download Ignite, build and set up benchmarks and only after 
> that run them.
> The goal of this task is to simplify the process in the following way:
> 1) ignite-yardstick benchmarks have to be pre-compiled and available with 
> every Ignite deliverable.
> 2) every deliverable must contain an executable (bat or sh file) with a clear 
> instruction on how to start a specific benchmark from the console.
> 3) the executable has to use some default yardstick configuration. The first 
> configuration should be intented for local execution (multicast IP finder) 
> and the second needs to be AWS oriented.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to