[ https://issues.apache.org/jira/browse/IGNITE-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871325#comment-15871325 ]
Roman Shtykh commented on IGNITE-4226: -------------------------------------- Hi [~anovikov], Thank you for pointing to {{IgniteUtils#containsStringCollection}}! Modified. As for creating {{GridRedisRestCommandHandler#longValue}}, it looks cleaner, but then you would have to iterate the same parameter list twice -- for _px_ and the second time for _ex_, like {code} Long px = longValue("px", params); Long ex = longValue("ex", params); if (px != null) restReq.ttl(px); else if (ex != null) restReq.ttl(ex * 1000L); {code} And the default value is not really needed here. I propose to leave {{setExpire}} as is, if there are no concerns, and generalize long value retrieval later when we have more code handling similar things. > Redis SET command should handle expirations > ------------------------------------------- > > Key: IGNITE-4226 > URL: https://issues.apache.org/jira/browse/IGNITE-4226 > Project: Ignite > Issue Type: Sub-task > Affects Versions: 1.8 > Reporter: Roman Shtykh > Assignee: Roman Shtykh > Labels: redis > Fix For: 2.0 > > > Handling EX and PX parameters of SET command. > https://redis.io/commands/set -- This message was sent by Atlassian JIRA (v6.3.15#6346)