[
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880836#comment-15880836
]
Andrey Gura commented on IGNITE-4587:
-------------------------------------
Hi, [~dreamx]
I've reviewed your pull request. First of all, please merge the latest changes
from master branch.
See my comments bellow:
# {{CacheAtomicWriteOrderMode}} enum contains now only one value {{PRIMARY}}.
Given the fact that this enum makes sense only for atomic cache I would prefer
to remove this enum. But better way is to discuss this on dev list. If there
are no any objectives then we can just remove this enum and all methods'
parameters of this type.
# {{GridDhtAtomicCache}} class {{isFastMap}} method always returns {{false}}
now. So this method is also candidate for removal.
# {{GridNearAtomicSingleUpdateFuture}} class {{mapSingleUpdate}} method.
Parameter {{updVer}} is always {{null}} now. Please remove this parameter. Also
please make sure that this parameter make sense for requests that will be
created in this method. It seems that
{{GridNearAtomicSingleUpdateFuture.updVer}} doesn't make sense also.
# {{GridNearAtomicUpdateFuture}} class. The same issue as for previous item but
for {{mapSingleUpdate}} and {{mapUpdate}} methods and {{updVer}} parameter.
> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> -----------------------------------------------------------
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
> Issue Type: Bug
> Components: cache
> Reporter: Denis Magda
> Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
