[
https://issues.apache.org/jira/browse/IGNITE-4823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926414#comment-15926414
]
Valentin Kulichenko commented on IGNITE-4823:
---------------------------------------------
Vyacheslav,
Very good catch on the bug! But the fix is completely wrong though :) Here are
my comments:
# First of all, you call {{putIfAbsent}} and then {{get}} but this is not
atomic and can produce incorrect result. There is {{getAndPutIfAbsent}} method
which you should use for this purpose.
# Do not remove {{withSkipStore}} flag for {{NULL}} value. It's a special flag
value and it doesn't make sense to persist it.
> SpringCache#putIfAbsent - wrong implementation
> ----------------------------------------------
>
> Key: IGNITE-4823
> URL: https://issues.apache.org/jira/browse/IGNITE-4823
> Project: Ignite
> Issue Type: Bug
> Components: cache
> Reporter: Vyacheslav Daradur
> Assignee: Vyacheslav Daradur
>
> *Current implementation:*
> {code}
> Object old;
> if (val == null)
> old = cache.withSkipStore().putIfAbsent(key, NULL);
> else
> old = cache.putIfAbsent(key, val);
> return old != null ? fromValue(old) : null;
> {code}
> cache.putIfAbsent(key, val) - return boolean, not cached value
> *Excepted behavior (according to the Spring-docs)*
> {code}
> Object existingValue = cache.get(key);
> if (existingValue == null) {
> cache.put(key, value);
> return null;
> } else {
> return existingValue;
> }
> {code}
> 1. Need to fix implementation
> 2. Cover SpringCache class with unit-tests
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
