[
https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928322#comment-15928322
]
ASF GitHub Bot commented on IGNITE-4795:
----------------------------------------
GitHub user SomeFire opened a pull request:
https://github.com/apache/ignite/pull/1630
IGNITE-4795
IGNITE-4795 TransactionException marker created.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SomeFire/ignite master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1630.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1630
----
commit 630f6db753e1fee024209cd122b7f3aae991cee4
Author: Дмитрий Рябов <[email protected]>
Date: 2017-03-06T12:53:27Z
Merge pull request #2 from apache/master
update
commit 009c3943fab8483cf72f4408595140be14e2410b
Author: Dmitrii Ryabov <[email protected]>
Date: 2017-03-07T12:50:51Z
TransactionException created and nested by concrete exceptions.
commit f006e1f202da292b1d29f09dc9fbee33f826dda3
Author: Dmitrii Ryabov <[email protected]>
Date: 2017-03-10T12:14:37Z
TransactionException created and nested by concrete exceptions.
commit 61a6a8e37775280a66ae28348f417f5874cb5373
Author: Dmitrii Ryabov <[email protected]>
Date: 2017-03-10T12:16:38Z
TransactionCheckedException created and nested by
IgniteTx...CheckedException.
Some IgniteCheckedException throws changed to TCE throws.
commit 1be332720846c2ec8ebe7bfca13c9d1fb63ff1d3
Author: Dmitrii Ryabov <[email protected]>
Date: 2017-03-14T14:31:16Z
Added note about visibility of changes inside transaction.
commit a771d755cc807a62832ae3a97918aca5c980ce35
Author: Дмитрий Рябов <[email protected]>
Date: 2017-03-16T15:55:35Z
IGNITE-4795
IGNITE-4795 TransactionExceptions.
----
> Inherit TransactionException and update Javadoc
> -----------------------------------------------
>
> Key: IGNITE-4795
> URL: https://issues.apache.org/jira/browse/IGNITE-4795
> Project: Ignite
> Issue Type: Improvement
> Components: cache, SQL, website
> Affects Versions: 1.8
> Reporter: Alexandr Kuramshin
> Assignee: Ryabov Dmitrii
> Labels: documentation
> Fix For: 2.0
>
>
> Understanding transactional behaviour is not clear in Javadoc at this point
> of time. Even after reading website some doubt remain.
> Proposal.
> 1. Create {{TransactionException}} as the marker of transactional methods and
> inherit from it all the existed transactional exceptions like
> {{TransactionTimeoutException}}, {{TransactionRollbackException}},
> {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc.
> 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc)
> as throwing the base {{TransactionException}}. Comment all the
> {{IgniteCache}} methods whether they are transactional or not, add {{@see
> TransactionException}} annotation.
> 3. Make extensive documentation in the header of {{TransactionException}} to
> get understanding of transactional and non-transactional methods behaviour.
> 4. Update website and Javadoc to clarify the fact that {{put}} value is
> cached within the transaction and affects successive {{get}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
