[
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931874#comment-15931874
]
Vyacheslav Daradur commented on IGNITE-3682:
--------------------------------------------
[~vozerov]
It's done already.
Without any refactoring and changes of code style. (the single changed class -
[see for
yourself|https://github.com/apache/ignite/pull/1614/files#diff-169436669aabfa588cd703b6ef6ae036])
Just anonymous classes were extracted. All classes in separate package.
Class names begin with the name of their type, just to be clear.
Merge-conflicts won't be because calls of GridFunc-methods didn't change.
[сi.tests|http://ci.ignite.apache.org/viewLog.html?buildId=504596] look good.
(.NET fails was just random, [previous is was
good|http://ci.ignite.apache.org/viewLog.html?buildId=504224&tab=buildResultsDiv&buildTypeId=IgniteTests_IgnitePlatformNet])
Decision up to you.
> GridFunc: move all inner anonymous classes to separate top-level classes.
> -------------------------------------------------------------------------
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
> Issue Type: Task
> Components: general
> Affects Versions: 1.6
> Reporter: Vladimir Ozerov
> Assignee: Vyacheslav Daradur
> Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
