[ 
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935287#comment-15935287
 ] 

Andrey Gura commented on IGNITE-602:
------------------------------------

[~SomeFire], this change doesn't fix the problem at all. The main goal is avoid 
of {{StackOverflowError}} due to a cyclic referencing. So class 
{{GridToStringBuilder}} should be fixed, not test.

Also your PR contains 95% formatting related changes. Please, don't do it in a 
such way anymore. It makes code review to difficult.

> [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by 
> infinite recursion
> --------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-602
>                 URL: https://issues.apache.org/jira/browse/IGNITE-602
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Artem Shutak
>            Assignee: Ryabov Dmitrii
>              Labels: Muted_test
>             Fix For: 2.0
>
>
> See test 
> org.gridgain.grid.util.tostring.GridToStringBuilderSelfTest#_testToStringCheckAdvancedRecursionPrevention
>  and related TODO in same source file.
> Also take a look at 
> http://stackoverflow.com/questions/11300203/most-efficient-way-to-prevent-an-infinite-recursion-in-tostring
> Test should be unmuted on TC after fix.
> see GG-5000.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to