[
https://issues.apache.org/jira/browse/IGNITE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935342#comment-15935342
]
Andrey Gura commented on IGNITE-4797:
-------------------------------------
[~kay_jpr] I've review your changes and have a few comments (see below):
# {{CacheMetricsSnapshot}} class has copying constructor that performs some
aggregations. It also should take into account system allocated size.
# {{CacheMetricsSnapshot}} class implements {{Externalizable}} interface.
Please add system allocation size serialization related code.
# System allocated size should be add to {{ClusterMetricsSnapshot}} class.
Please look at usage of {{nonHeapUsed}} field and implement logic in a similar
way.
# It seems that better name for method in MBean is
{{getOffheapSystemAllocatedSize}}.
Could you please fix this comments.
> Need to expose offheap memory allocated size metric for internal data
> structures
> --------------------------------------------------------------------------------
>
> Key: IGNITE-4797
> URL: https://issues.apache.org/jira/browse/IGNITE-4797
> Project: Ignite
> Issue Type: Improvement
> Reporter: Andrey Gura
> Assignee: Kartik Somani
> Labels: newbie
> Fix For: 2.0
>
>
> Offheap caches expose offheap memory allocated size via
> {{CacheMetricsMXBean.getOffHeapAllocatedSize()}}. But this metric doesn't
> take into account offheap memory that allocated for internal data structures
> (GridUnsafeMap and LRU eviction policy).
> However Ignite collects this metric (see
> GridUnsafeMemory.systemAllocatedSize() method).
> Need to expose this metric via {{CacheMetricsMXBean}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
