[
https://issues.apache.org/jira/browse/IGNITE-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936364#comment-15936364
]
ASF GitHub Bot commented on IGNITE-2703:
----------------------------------------
GitHub user ptupitsyn opened a pull request:
https://github.com/apache/ignite/pull/1664
IGNITE-2703 .NET: Dynamic type registration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-2703
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1664.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1664
----
commit 792506a63572b0b50e47b11c3a6e54065768ac98
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-02-10T11:56:55Z
IGNITE-2703 .NET: Dynamic type registration
commit 4588e455889025487bbd1c27ef7fe732cfcb1b4c
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-02-15T13:48:54Z
Merge branch 'ignite-2.0' into ignite-2703
# Conflicts:
#
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryContext.java
commit d7c6a7f2f898b489cdd137e17f2ed5203d39c3d0
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-02-15T15:31:39Z
Fix ExecutableTest
commit 8d6e9963a8fdd846fa64c5db1f431a609e0e7d5d
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-02-15T15:33:27Z
Remove unused imports
commit 4ee6e26710cd3d95827eeb60042dde384a56e4bd
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-02-15T15:38:38Z
Fix typos
commit 32a01d20412608dce29190a9ed5e80d077ea9dcf
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-02-16T12:49:53Z
Merge branch 'ignite-2.0' into ignite-2703
commit 88e844b25c5595ad5b7f98fbce142e6e8f77a9dd
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-02-16T12:56:01Z
Fix TestEchoTaskBinarizableNoClass
commit 827887fac0dc75fbed3a583b8ae690256fe6eca7
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-02-16T13:01:02Z
Fix TestDelegate
commit 72ad8a585d8d40b0edc0fbb23f6c410d0b7682ae
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-02-16T13:06:45Z
Disable type registration in system marshaller to avoid unexpected conflicts
commit 706bba2cc05b8ece689dab3d398815fc826d41a0
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-02-16T13:08:47Z
Remove unused BinaryStreamAdapter
commit c205e6d518a2147592b23bccb141072cf682f248
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-03-22T14:00:08Z
Merge branch 'master' into ignite-2703
# Conflicts:
#
modules/platforms/dotnet/Apache.Ignite.Core.Tests/Binary/Serializable/AdvancedSerializationTest.cs
# modules/platforms/dotnet/Apache.Ignite.Core/Common/IgniteGuid.cs
# modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/Marshaller.cs
commit 949f8ec9e06665ff35312e799b20bf5b1736ee13
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-03-22T14:05:42Z
Fix merge
----
> .NET: Dynamically registered classes must use binary serialization if possible
> ------------------------------------------------------------------------------
>
> Key: IGNITE-2703
> URL: https://issues.apache.org/jira/browse/IGNITE-2703
> Project: Ignite
> Issue Type: Task
> Components: platforms
> Affects Versions: 1.5.0.final
> Reporter: Vladimir Ozerov
> Assignee: Pavel Tupitsyn
> Labels: .net, breaking-api
> Fix For: 2.0
>
>
> At present we support dynamic class registration in .NET, but they are
> written using deafult .NET mechanism. This is counterintuitive for users and
> not consistent with Java, where such classes are written in binary form.
> Proposed implementation plan:
> 1) For each dynamically registered class we must understand whether it could
> be serialized through binary or not. If not - print a warning and fallback to
> .NET.
> 2) Before writing a class we must ensure that it's [typeId -> name] pair is
> known to the cluster. If not - write full class name instead of type ID. Java
> already do that.
> 3) Last, to support backward compatibility we must be able to fallback to
> current mode with help of some boolean flag.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
