[
https://issues.apache.org/jira/browse/IGNITE-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952012#comment-15952012
]
Valentin Kulichenko commented on IGNITE-4812:
---------------------------------------------
[~alpert], the fix itself looks good, but I don't like multiple changes in old
tests. Please do the following:
* Revert all these changes of {{getConfiguration}} method in tests.
* Instead modify {{GridAbstractTest.getConfiguration(String igniteInstanceName,
IgniteTestResources rsrcs)}} method to use {{MemoryEventStorageSpi}} by
default, so that nothing changes for any of tests that already exist.
* In any new tests that require {{NoopEventStorageSpi}}, set it explicitly.
* Rerun TC and check that everything is fine.
> Disable EventStorageSpi by default
> ----------------------------------
>
> Key: IGNITE-4812
> URL: https://issues.apache.org/jira/browse/IGNITE-4812
> Project: Ignite
> Issue Type: Bug
> Components: general
> Affects Versions: 1.9
> Reporter: Valentin Kulichenko
> Assignee: Alper Tekinalp
> Fix For: 2.0
>
>
> Current default implementation of {{EventStorageSpi}} is
> {{MemoryEventStorageSpi}}. It consumes a lot of memory, while is used only
> for events querying (i.e. not listening), which is a fairly rare use case.
> Need to:
> * Introduce {{NoOpEventStorageSpi}}.
> * Make {{NoOpEventStorageSpi}} the default one.
> * Throw an exception when {{IgniteEvents#localQuery}} or {{#remoteQuery}}
> method is called with default setting. Exception message should explain how
> to fix it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
