[ 
https://issues.apache.org/jira/browse/IGNITE-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956679#comment-15956679
 ] 

ASF GitHub Bot commented on IGNITE-4885:
----------------------------------------

GitHub user ptupitsyn opened a pull request:

    https://github.com/apache/ignite/pull/1733

    IGNITE-4885 .NET: Disallow abstract and open generic types in 
BinaryConfiguration

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ptupitsyn/ignite ignite-4885

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1733.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1733
    
----
commit 3122c258fc7a7f3969e33f3c24dc3af568c13255
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-05T10:00:50Z

    IGNITE-4885 .NET: Meaningless exception on generic type in 
BinaryConfiguration

commit 7af83635c23d8a24e4763c226e922f2245bb8cf8
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-05T10:28:20Z

    wip

commit c96db8a12a6e40bff82cf75b568b601cfab5d263
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-05T10:31:07Z

    Fix exception propagation

commit 06dd3289cdce8a3fb6eeb77c727833dfa0ac3d4c
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-05T10:34:15Z

    wip

commit 270c881e8f6e7e175ea3a8c166e029231c1ccb00
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-05T10:39:02Z

    Add type validation

commit 29bb64949811ec474eac38a53f587d3a2d48f604
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-05T10:52:35Z

    Add check for abstract types

commit f79c138aceb9702ce746631f30cc363b9dc4dd30
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-05T11:05:19Z

    Fix tests

----


> .NET: Meaningless exception on generic type in BinaryConfiguration
> ------------------------------------------------------------------
>
>                 Key: IGNITE-4885
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4885
>             Project: Ignite
>          Issue Type: Bug
>          Components: platforms
>    Affects Versions: 1.6
>            Reporter: Pavel Tupitsyn
>            Assignee: Pavel Tupitsyn
>              Labels: .NET
>             Fix For: 2.0
>
>
> {{BinaryTypeConfiguration}} does not support open generic types (when 
> parameters are not specified, like {{typeof(List<>)}} instead of 
> {{typeof(List<int>}}). But the exception is not helpful, and stack trace is 
> very short (because of native transition).
> We should try to provide meaningful exception message and a proper stack 
> trace.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to