[
https://issues.apache.org/jira/browse/IGNITE-4899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956780#comment-15956780
]
ASF GitHub Bot commented on IGNITE-4899:
----------------------------------------
GitHub user ptupitsyn opened a pull request:
https://github.com/apache/ignite/pull/1738
IGNITE-4899 .NET: Review Dictionary usage in APIs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptupitsyn/ignite ignite-4899
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1738.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1738
----
commit 68f2417e452ccb4faf2bb4c9fc302a4f90dc3f8e
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-04-05T12:04:40Z
PutAll refactored
commit 31812f03e503827b1f8b0ab3e79d5dc0dd784294
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-04-05T12:17:43Z
Refactor GetAll & GetAllAsync
commit aefa134f4a826d64ae2d11eda6a42a877eb48874
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-04-05T12:20:14Z
Fix example
commit 41d1c749383d728fa6d5c28a066a7a17e52abada
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-04-05T12:30:38Z
wip InvokeAll
commit 8b58574337c633fae47211cf9f8dd98b402f2779
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-04-05T12:32:05Z
InvokeAll done
----
> .NET: Review Dictionary usage in APIs
> -------------------------------------
>
> Key: IGNITE-4899
> URL: https://issues.apache.org/jira/browse/IGNITE-4899
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 2.0
> Reporter: Pavel Tupitsyn
> Assignee: Pavel Tupitsyn
> Labels: .NET, breaking-api
> Fix For: 2.0
>
>
> We have replaced {{IDictionary}} with {{IEnumerable<KeyValuePair<TK, TV>>}}
> in {{ICacheStore}}, let's do the same for other APIs like {{ICache.GetAll}}.
> Reading GetAll results into a dictionary is inefficient in case when user
> only needs to iterate over results (unneeded allocation and hashing).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
