[ 
https://issues.apache.org/jira/browse/IGNITE-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993619#comment-15993619
 ] 

ASF GitHub Bot commented on IGNITE-5135:
----------------------------------------

GitHub user ptupitsyn opened a pull request:

    https://github.com/apache/ignite/pull/1899

    IGNITE-5135 .NET: Improve remote error propagation

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ptupitsyn/ignite ignite-5135

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1899.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1899
    
----
commit 65be9fcb15050cfc71939bac0f232495eb812108
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-05-02T14:20:30Z

    IGNITE-5135 .NET: Improve remote error propagation

commit 209716a4e357687f61ef7a902f16649cafdf0d80
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-05-02T14:30:38Z

    wip

commit 1b38c3baf773e39d8b4f1883213d354a7139a56d
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-05-02T14:31:22Z

    wip

commit 3f63d82973113a695879730103cfd213be79a5af
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-05-02T14:37:18Z

    Tests fixed

----


> .NET: Improve remote error propagation
> --------------------------------------
>
>                 Key: IGNITE-5135
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5135
>             Project: Ignite
>          Issue Type: Improvement
>          Components: platforms
>            Reporter: Pavel Tupitsyn
>            Assignee: Pavel Tupitsyn
>            Priority: Minor
>             Fix For: 2.1
>
>
> When we rethrow remote exceptions, we should wrap them in another exception 
> to preserve remote stack traces.
> For example, {{ComputeAbstractClosureTask.OnResult}} uses {{throw err}}, 
> where {{err}} is a deserialized remote exception. This call causes remote 
> stack trace loss.
> Instead we should do {{throw new IgniteException("Remote computation failed", 
> err)}} which will preserve remote stack trace.
> Same should be done for other remote invocation scenarios (event listeners 
> and so on).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to