[
https://issues.apache.org/jira/browse/IGNITE-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997291#comment-15997291
]
ASF GitHub Bot commented on IGNITE-5172:
----------------------------------------
GitHub user ptupitsyn opened a pull request:
https://github.com/apache/ignite/pull/1909
IGNITE-5172 .NET: Fix type name resolving during dynamic registration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptupitsyn/ignite ignite-5172
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1909
----
commit 190476e55d29214d8c5dd87523e70abb58175efa
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-05-04T18:07:35Z
IGNITE-5172 .NET: Fix type name mapping for dynamic registration
commit 95e0c20285c8b84307753b09eff5c8aea8efde95
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-05-04T18:48:26Z
Add test
commit 7fefe5f60a505b85e0d03576de18bc70e52ec677
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-05-04T18:50:31Z
Fix compilation
commit 435a91a3258615e0e4fc1a1e23dab96687ddb1f0
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-05-04T19:13:02Z
Fixing TypeResolver
commit 31435b3ae30d7326c5ec726c3806e9074b1d02ee
Author: Pavel Tupitsyn <[email protected]>
Date: 2017-05-04T19:23:51Z
Fixing generic type resolver
----
> .NET: Dynamic type registration uses assembly-qualified type name
> -----------------------------------------------------------------
>
> Key: IGNITE-5172
> URL: https://issues.apache.org/jira/browse/IGNITE-5172
> Project: Ignite
> Issue Type: Bug
> Components: platforms
> Affects Versions: 2.0
> Reporter: Pavel Tupitsyn
> Assignee: Pavel Tupitsyn
> Labels: .NET
> Fix For: 2.1
>
>
> {{BinaryProcessor.RegisterType}} uses {{AssemblyQualifiedName}}, which
> includes assembly version.
> This has two issues:
> * We ignore current name mapper, so this type name is not the same as type
> name in binary metadata, marshaller, etc
> * This breaks when same type comes from assemblies with different versions,
> which is a valid scenario. Binary protocol is flexible and does not care
> about type versions, it tolerates new or missing fields.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
