[
https://issues.apache.org/jira/browse/IGNITE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998519#comment-15998519
]
Ivan Rakov edited comment on IGNITE-5151 at 5/5/17 4:20 PM:
------------------------------------------------------------
Roman, I've looked through your changes and fix looks wrong to me. First of
all, in default cache configuration warning will be shown after first
cache.put().
Offheap eviction is page-memory-wide mechanism, unlike cache-wide regular
eviction, which is manageable by EvictionManager of specific cache. Both
eviction mechanisms can be active at the same time, and it's incorrect to show
only one warning for both of them.
I think, the best place to show warning for offheap eviction is under
_shouldEvict_ flag of _IgniteCacheDatabaseSharedManager#ensureFreeSpace_ method.
was (Author: ivan.glukos):
Roman, I've looked through your changes and fix looks wrong to me.
Offheap eviction is page-memory-wide mechanism, unlike cache-wide regular
eviction, which is manageable by EvictionManager of specific cache. Both
eviction mechanisms can be active at the same time, and it's incorrect to show
only one warning for both of them.
I think, the best place to show warning for offheap eviction is under
_shouldEvict_ flag of _IgniteCacheDatabaseSharedManager#ensureFreeSpace_ method.
> Add some warning when offheap eviction occurs
> ---------------------------------------------
>
> Key: IGNITE-5151
> URL: https://issues.apache.org/jira/browse/IGNITE-5151
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 2.0
> Reporter: Ksenia Rybakova
> Assignee: Roman Shtykh
>
> Currently if offheap eviction occurs we are silently losing data. It whould
> be helpful to have some warning in log as it's done for onheap eviction.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
