[
https://issues.apache.org/jira/browse/IGNITE-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019472#comment-16019472
]
Vladimir Ozerov edited comment on IGNITE-5163 at 5/22/17 11:41 AM:
-------------------------------------------------------------------
[~tledkov-gridgain], my comments:
1) {{SqlListenerRequestHandlerImpl}} - It is illegal to create cache if it
doesn't exist. Client cannot start cache. Let's remove this logic altogether
and ensure that ODBC tests work
2) {{JdbcConnection.ctor}} - catch {{Exception}}, not {{Throwable}}
3) {{JdbcConnection.ctor}} - I do not see any validation for passed host and
port. Neither I do see use of default port. Let's add this logic and add
relevant tests (both positive and negative).
4) Do not use {{JavaLogger}}. Let's do the same as we did in {{GridClientImpl}}
- use {{java.util.logging}}.
5) {{JdbcTcpIo.read}} - I still has doubts on it's correctness. JavaDoc says
"This method blocks until *some* input is available". I am not sure that
returning less data than we expect is an error, unless {{-1}} is received.
Let's fix that.
was (Author: vozerov):
[~tledkov-gridgain], my comments:
1) {{SqlListenerRequestHandlerImpl}} - It is illegal to create cache if it
doesn't exist. Client cannot start cache. Let's remove this logic altogether
and ensure that ODBC tests work
2) {{JdbcConnection.ctor}} - catch {{Exception}}, not {{Throwable}}
3) {{JdbcConnection.ctor}} - I do not see any validation for passed host and
port. Neither I do see use of default port. Let's add this logic and add
relevant tests (both positive and negative).
4) Do not use {{JavaLogger}}. Let's do the same as we did in {{GridClientImpl}}
- use {{java.util.logging}}.
5) {{JdbcTcpIo.read}} - I still has doubts on it's correctness. JavaDoc says
"This method blocks until *some* input is available". I am not sure that
returning less data than we expect is an error, unless "-1" is received. Let's
fix that.
> JDBC Driver: implement handshake for thin jdbc driver based on common
> odbc/jdbc protocol
> ----------------------------------------------------------------------------------------
>
> Key: IGNITE-5163
> URL: https://issues.apache.org/jira/browse/IGNITE-5163
> Project: Ignite
> Issue Type: Task
> Components: odbc, sql
> Affects Versions: 1.9
> Reporter: Taras Ledkov
> Assignee: Taras Ledkov
> Fix For: 2.1
>
>
> The GridClient must be removed from thin jdbc driver.
> It is the first step to unify JDBC & ODBC protocols.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
