[
https://issues.apache.org/jira/browse/IGNITE-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073362#comment-16073362
]
ASF GitHub Bot commented on IGNITE-5554:
----------------------------------------
GitHub user mcherkasov opened a pull request:
https://github.com/apache/ignite/pull/2230
IGNITE-5554 ServiceProcessor may process failed reassignments in timeout
thread
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-5554
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/2230.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2230
----
commit 7734a7d0adbd5f43bcaa4d726231388fcd0d4784
Author: mcherkasov <[email protected]>
Date: 2017-06-30T17:23:55Z
Deployment re-try operations are moved to deployment executor.
----
> ServiceProcessor may process failed reassignments in timeout thread
> -------------------------------------------------------------------
>
> Key: IGNITE-5554
> URL: https://issues.apache.org/jira/browse/IGNITE-5554
> Project: Ignite
> Issue Type: Bug
> Components: managed services
> Affects Versions: 1.7
> Reporter: Alexey Goncharuk
> Assignee: Mikhail Cherkasov
> Fix For: 2.1
>
>
> The following parts of GridServiceProcessor look wrong to me:
> In GridServiceProcessor.TopologyListener#onReassignmentFailed
> {code}
> @Override public void onTimeout() {
> onReassignmentFailed(topVer, retries);
> }
> {code}
> And in GridServiceProcessor#onDeployment
> {code}
> @Override public void onTimeout() {
> .....
> // Try again.
> onDeployment(dep, topVer);
> }
> {code}
> The rest of ServiceProcessor relies on the deployments being processed in a
> single thread, while this code will be executed in the timeout processor
> thread. Not only can it take a lot of time to reassign, which will stall the
> timeout thread, but it may also break the service assignment logic.
> The corresponding calls should be wrapped to runnables and submitted to the
> depExe.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
