[
https://issues.apache.org/jira/browse/IGNITE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096118#comment-16096118
]
Pavel Tupitsyn commented on IGNITE-5791:
----------------------------------------
[~chief] my comments:
* All {{TODO}}s must include JIRA links, see
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-TODOs
* {{Matrix.java}} has commented-out {{map}} method, please remove.
* Argument validation is missing in some places. Internal code (example:
{{CacheUtils}}) should use {{assert}}, public APIs (example:
{{SparseBlockDistributedMatrix.times()}}, mtx can be null) must throw
exceptions for invalid arguments.
* {{checkRowIndex}}: Should we include rowSize in exception text instead of
writing this to console?
> Block matrix Introduction
> -------------------------
>
> Key: IGNITE-5791
> URL: https://issues.apache.org/jira/browse/IGNITE-5791
> Project: Ignite
> Issue Type: Sub-task
> Components: ml
> Reporter: Yury Babak
> Assignee: Yury Babak
> Fix For: 2.2
>
>
> Introduction of sparce distributed block matrix with more efficient
> multiplication rather than row/col distributed matrix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)