[
https://issues.apache.org/jira/browse/IGNITE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110739#comment-16110739
]
Sergey Chugunov edited comment on IGNITE-5542 at 8/2/17 11:30 AM:
------------------------------------------------------------------
[~sboikov], I've addressed both points:
* Removed unnecessary method and moved all checks to existing {{checkCache}}
method. I used it instead of suggested {{validateCacheGroupConfiguration}}
because the latter one is responsible for validating different caches within
the same cache group before sending join request; while the former does exactly
what I need: it compares remote cache configuration with local one.
* Additional test case was created.
I also merged latest changes from master to my branch and checked [TC
status|http://ci.ignite.apache.org/viewLog.html?buildId=751953]; it hasn't
shown any test failures related to my change.
Thanks,
Sergey.
was (Author: sergey-chugunov):
[~sboikov], I've addressed both points:
* Removed unnecessary method and moved all checks to existing {{checkCache}}
method. I used it instead of suggested {{validateCacheGroupConfiguration}}
because the latter one is responsible for validating different caches within
the same cache group; while the former does exactly what I need: it compares
remote cache configuration with local one.
* Additional test case was created.
I also merged latest changes from master to my branch and checked [TC
status|http://ci.ignite.apache.org/viewLog.html?buildId=751953]; it hasn't
shown any test failures related to my change.
Thanks,
Sergey.
> Assertion failure in IgniteBasic test
> IgniteCacheP2pUnmarshallingRebalanceErrorTest.testResponseMessageOnUnmarshallingFailed
>
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-5542
> URL: https://issues.apache.org/jira/browse/IGNITE-5542
> Project: Ignite
> Issue Type: Test
> Reporter: Dmitriy Pavlov
> Assignee: Sergey Chugunov
> Labels: MakeTeamcityGreenAgain, test-fail
>
>
> http://ci.ignite.apache.org/viewLog.html?buildId=674131&tab=buildResultsDiv&buildTypeId=Ignite20Tests_IgniteBasic#testNameId-7204444637123828878
> org.apache.ignite.internal.processors.cache.IgniteCacheP2pUnmarshallingRebalanceErrorTest#testResponseMessageOnUnmarshallingFailed
> assertion failed,
> *stable reproducable locally*
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
