[ 
https://issues.apache.org/jira/browse/IGNITE-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116342#comment-16116342
 ] 

Vladimir Ozerov commented on IGNITE-5211:
-----------------------------------------

[~tledkov-gridgain], my comments:
1) I do not see reverts of {{queryEntity}} setter. There should not be 3-4 
changed classes in patch, not 100.
2) New classes are query-specific, and hence should reside in query internal 
package, not inside {{cache.configuration}}.

> Classes based constructor for QueryEntities
> -------------------------------------------
>
>                 Key: IGNITE-5211
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5211
>             Project: Ignite
>          Issue Type: Task
>          Components: sql
>            Reporter: Denis Magda
>            Assignee: Taras Ledkov
>            Priority: Critical
>             Fix For: 2.2
>
>
> We need to add constructor {{QueryEntity(Class keyType, Class valueType)}} to 
> query entities class and deprecate {{CacheConfiguration.setIndexedTypes(…)}} 
> method.
> Otherwise, there is no easy way for people who define SQL scheme with the 
> annotations to do advanced settings like names of key and value objects, 
> table name, etc.
> See this discussion for more details:
> http://apache-ignite-developers.2346864.n4.nabble.com/SQL-setting-key-field-name-for-types-registered-via-CacheConfiguration-setIndexedTypes-td17603.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to