Andrew Mashenkov commented on IGNITE-5468:

PR looks fine for me.

One thing bother me I've no idea to make better.
This is how we validate IGNITE_SQL_MERGE_TABLE_MAX_SIZE parameter and fallback 
to default if there is any issue.
Code looks too complex.

[~avinogradov] please take a look at it and merge if its ok for you.

> Need to set IGNITE_SQL_MERGE_TABLE_MAX_SIZE on per query basis
> --------------------------------------------------------------
>                 Key: IGNITE-5468
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5468
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>    Affects Versions: 2.0
>            Reporter: Yakov Zhdanov
>            Assignee: Vitaliy Biryukov 
>            Priority: Critical
>             Fix For: 2.2
> Currently this property can be set via sys property only thus changing it 
> will require restart of the cluster. I think it is better to set it on 
> perquery basis with some default that is configured via cache configuration.

This message was sent by Atlassian JIRA

Reply via email to