[
https://issues.apache.org/jira/browse/IGNITE-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127197#comment-16127197
]
Max Shonichev edited comment on IGNITE-6064 at 8/15/17 1:52 PM:
----------------------------------------------------------------
current output for both successful activation:
{noformat}
10.116.206.1:11214 - was activate
{noformat}
and unsuccessful activation:
{noformat}
Something fail during activation, exception message: Failed to perform request
(connection failed): /10.116.215.130:11214
{noformat}
proposed:
for 'activate' command, we have following cases :
1. grid was not active and was activated by 'activate' command
2. grid was already active and 'activate' command left it active
3. grid was not active and activation failed due to error
for 1 and 2 we should return 0 exit code from script and print following
messages:
"successfully activated"
"was already active"
for 3 we should return != 0 exit code and print following message:
"activation failed due to error: ..."
for 'deactivate' command, we have following cases :
4. grid was not active and 'deactivate' command left it inactive
5. grid was active and was deactivated
6. grid was active but some exception happens upon deactivation
for 4 and 5 we should return 0 exit code from script and print following
messages:
"was already inactive"
"successfully deactivated"
for 6 we should return != 0 exit code and print following message:
"deactivation failed due to error: ..."
as of prefix before message, the current CLUSTER_IP:PORT looks good to me
was (Author: mshonichev):
current output for both successful activation:
{noformat}
10.116.206.1:11214 - was activate
{noformat}
and unsuccessful activation:
{noformat}
Something fail during activation, exception message: Failed to perform request
(connection failed): /10.116.215.130:11214
{noformat}
proposed:
for 'activate' command, we have following cases :
1. grid was not active and was activated by 'activate' command
2. grid was already active and 'activate' command left it active
3. grid was not active and activation failed due to error
for 1 and 2 we should return 0 exit code from script and print following
messages:
"successfully activated"
"was already active"
for 3 we should return != 0 exit code and print following message:
"activation failed due to error: ..."
for 'deactivate' command, we have following cases :
4. grid was not active and 'deactivate' command left it inactive
5. grid was active and was deactivated
6. grid was active but some exception happens upon deactivation
for 4 and 5 we should return 0 exit code from script and print following
messages:
"was already inactive"
"successfully deactivated"
for 6 we should return != 0 exit code and print following message:
"deactivation failed due to error: ..."
> Rework control.sh script
> ------------------------
>
> Key: IGNITE-6064
> URL: https://issues.apache.org/jira/browse/IGNITE-6064
> Project: Ignite
> Issue Type: Improvement
> Components: general
> Affects Versions: 2.0, 2.1
> Reporter: Dmitriy Govorukhin
> Fix For: 2.2
>
>
> Current behavior control.sh is not clear.
> 1. control.sh is a confusing name, need more suitable name.
> 2. Print help description if incorrect command was entered
> 3. Do not print stacktrace if connection fail, add more conveniently message.
> 4. Print information about connection, like "Connecting to
> [ip-address]:[port] etc."
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
