[
https://issues.apache.org/jira/browse/IGNITE-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141576#comment-16141576
]
Taras Ledkov edited comment on IGNITE-6125 at 8/25/17 12:55 PM:
----------------------------------------------------------------
The patch is OK with me.
We have to review {{jdbc2.JdbcDatabaseMetadata}} and implement some methods
correctly.
- getTypeInfo() now returns empty results set.
- pay attention to the all methods that return empty result set. Now the
result's metadata isn't available.
Please file separate tickets for these tasks.
was (Author: tledkov-gridgain):
The patch is OK with me.
We have to review {{jdbc2.JdbcDatabaseMetadata}} and implement some methods
correctly.
- getTypeInfo() now returns empty results set.
- pay attention to the all methods that return empty result set. Now the
result's metadata isn't available.
> Improve robustness for JDBC driver metadata queries
> ---------------------------------------------------
>
> Key: IGNITE-6125
> URL: https://issues.apache.org/jira/browse/IGNITE-6125
> Project: Ignite
> Issue Type: Task
> Components: clients, jdbc
> Affects Versions: 2.1
> Reporter: Ilya Kasnacheev
> Assignee: Ilya Kasnacheev
> Fix For: 2.2
>
>
> org.apache.ignite.internal.jdbc2.JdbcDatabaseMetadata is in worrysome state:
> - Makes frivolous use of toUpperCase() to address former.
> - getPrimaryKeys() never returns anything because of defective use of
> toUpperCase().
> - No tests on indexes, primary keys, schemas or parameters metadata retrieval.
> - Ignores "catalog" parameter instead of checking if it matches empty catalog.
> - See also IGNITE-6138, IGNITE-6139
> That should be fixes without compromising backwards compatibility too much.
> Tests may be borrowed from thin client implementation.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
