[
https://issues.apache.org/jira/browse/IGNITE-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158436#comment-16158436
]
Vladimir Ozerov commented on IGNITE-4172:
-----------------------------------------
[~asfedotov], my comments:
1) What is the purpose of changes to {{osgi-karaf/pom.xml}}?
2) Changes to the main {{pom.xml}} should be reviewed by build subsystem
experts ([~avinogradov], [~oleg-ostanin])
3) {{Jsr310Java8DateTimeApiUtils}} - I see unused methods in this class, is it
fine?
4) {{Jsr310Java8DateTimeApiUtils}} - empty method bodies should have {{//
No-op}} inside.
5) Tests - please rewrite them so that neither "_key", nor "_val" ever used.
These are internal fields which are not shown to users normally. Instead, you
should define normal classes with date/time fields and query them.
6) {{CacheQueryJsr310Java8DateTimeApiSupportTestSuite}} - is it included into
any TeamCity suite? If not, let's create and configure one.
> SQL: Add support for Java 8 Time API classes in date\time functions
> -------------------------------------------------------------------
>
> Key: IGNITE-4172
> URL: https://issues.apache.org/jira/browse/IGNITE-4172
> Project: Ignite
> Issue Type: Bug
> Components: sql
> Affects Versions: 2.0
> Reporter: Andrew Mashenkov
> Assignee: Alexandr Fedotov
> Labels: usability
> Fix For: 2.3
>
>
> We have is issue with querying LocalDateTime objects with our SQL engine.
> Next query can fails with error, if one of row localDateTimeField value has
> zero-time:
> select DATEDIFF('DAY', localDateTimeField, CURRENT_DATE ()) from t;
> Startpoint is IgniteH2Indexing.wrap() method.
> We need add support to these classes: LocalDate, LocalTime, LocalDateTime.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
