[ https://issues.apache.org/jira/browse/IGNITE-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160473#comment-16160473 ]
ASF GitHub Bot commented on IGNITE-6307: ---------------------------------------- GitHub user nizhikov opened a pull request: https://github.com/apache/ignite/pull/2629 IGNITE-6307: Remove new local entries from onHeap map Remove new local entries from onHeap map in case of Exception inside getAll You can merge this pull request into a Git repository by running: $ git pull https://github.com/nizhikov/ignite IGNITE-6307 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2629.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2629 ---- commit 2c3dbfa95d25ca837624cc5f69c612134a65e39f Author: Nikolay Izhikov <nizhikov....@gmail.com> Date: 2017-09-10T20:36:02Z IGNITE-6307: Remove new local entries from onHeap map in case of Exception inside getAll ---- > If getAll() fails with NPE, onHeap entry is not removed, for local cache > ------------------------------------------------------------------------ > > Key: IGNITE-6307 > URL: https://issues.apache.org/jira/browse/IGNITE-6307 > Project: Ignite > Issue Type: Bug > Components: cache > Affects Versions: 2.0 > Reporter: Dmitriy Govorukhin > Assignee: Nikolay Izhikov > Labels: MakeTeamcityGreenAgain > Fix For: 2.3 > > > GridCacheLocalFullApiSelfTest.testGetAllWithNulls > {code} > final Set<String> c = new HashSet<>(); > c.add("key1"); > c.add(null); > GridTestUtils.assertThrows(log, new Callable<Void>() { > @Override public Void call() throws Exception { > cache.getAll(c); > return null; > } > }, NullPointerException.class, null); > {code} > After getAll, entry with "key1" will be in heap map, it is dependent of order > in collection for getAll(); -- This message was sent by Atlassian JIRA (v6.4.14#64029)