[
https://issues.apache.org/jira/browse/IGNITE-5960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163149#comment-16163149
]
Alexey Kuznetsov edited comment on IGNITE-5960 at 9/12/17 3:52 PM:
-------------------------------------------------------------------
failure scenario pseudo-code:
Suppose we have 3 instances of GridCacheMapEntry: E1, E2, E3.
Which got updated in threads T1, T2, T3 respectively.
User hasn't set any continuous query listeners yet.
Threads update entries by CacheMapEntry#innerUpdate()
1)T1 invokes cctx.continuousQueries().updateListeners() and got null.
2)User set continuous query listener
3)T2 invokes cctx.continuousQueries().updateListeners() and got listeners
4)T2 evaluates updateCounter to 1 for E2(c.updateRes.updateCounter())
5)T1 evaluates updateCounter to 2 for E1(c.updateRes.updateCounter())
6)T2 evaluates cctx.continuousQueries().onEntryUpdated() and processes
continuous entry
7)T1 doesn't evaluate cctx.continuousQueries().onEntryUpdated()(because
listeners are null)
All entries are placed in CacheContinuousQueryEventBuffer.Batch#_entries_
before being processed.
So, now there is only E2 in _entries_ array.
8)T3 evaluates update counter 3 and put it into _entries_ array.
Now, E3 would not been sent to users's listener due to E2 abscense in
_entries_. Next entries would not been sent to user because
CacheContinuousQueryEventBuffer.Batch#processEntry0 doesn’t return resulting
entities(they just accumulate in _entries_).
was (Author: alexey kuznetsov):
failure scenario pseudo-code:
Suppose we have 3 instances of GridCacheMapEntry: E1, E2, E3.
Which got updated in threads T1, T2, T3 respectively.
User hasn't set any continuous query listeners yet.
Threads update entries by CacheMapEntry#innerUpdate()
1)T1 invokes cctx.continuousQueries().updateListeners() and got null.
2)User set continuous query listener
3)T2 invokes cctx.continuousQueries().updateListeners() and got listeners
4)T2 evaluates updateCounter to 1 for E2(c.updateRes.updateCounter())
5)T1 evaluates updateCounter to 2 for E1(c.updateRes.updateCounter())
6)T2 evaluates cctx.continuousQueries().onEntryUpdated() and processes
continuous entry
7)T1 doesn't evaluate cctx.continuousQueries().onEntryUpdated()(because
listeners are null)
All entries are placed in CacheContinuousQueryEventBuffer.Batch#_entries_
before being processed.
So, now there is only E2 in _entries_ array.
8)T3 evaluates update counter 3 and put it into _entries_ array.
Now, E3 would not been sent to users's listener due to E2 abscense in
_entries_. Next entries would not been sent to user because
CacheContinuousQueryEventBuffer.Batch#processEntry0 doesn’t return resulting
entities(they just accumulate in entries).
> Ignite Continuous Query (Queries 3):
> CacheContinuousQueryConcurrentPartitionUpdateTest::testConcurrentUpdatesAndQueryStartAtomic
> is flaky
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-5960
> URL: https://issues.apache.org/jira/browse/IGNITE-5960
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Sergey Chugunov
> Assignee: Alexey Kuznetsov
> Labels: MakeTeamcityGreenAgain, test-failure
> Fix For: 2.3
>
>
> According to [TC
> history|http://ci.ignite.apache.org/project.html?projectId=Ignite20Tests&testNameId=6546112007182082024&tab=testDetails&branch_Ignite20Tests=%3Cdefault%3E]
> test is flaky.
> It is possible to reproduce it locally, sample run shows 9 failed tests out
> of 30 overall executed.
> Test fails with jUnit assertion check:
> {noformat}
> junit.framework.AssertionFailedError:
> Expected :10000
> Actual :0
> <Click to see difference>
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.failNotEquals(Assert.java:329)
> at junit.framework.Assert.assertEquals(Assert.java:78)
> at junit.framework.Assert.assertEquals(Assert.java:234)
> at junit.framework.Assert.assertEquals(Assert.java:241)
> at junit.framework.TestCase.assertEquals(TestCase.java:409)
> at
> org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryConcurrentPartitionUpdateTest.concurrentUpdatesAndQueryStart(CacheContinuousQueryConcurrentPartitionUpdateTest.java:385)
> at
> org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryConcurrentPartitionUpdateTest.testConcurrentUpdatesAndQueryStartTx(CacheContinuousQueryConcurrentPartitionUpdateTest.java:245)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2000)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:132)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:1915)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
