[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166373#comment-16166373
]
Vyacheslav Daradur commented on IGNITE-5097:
--------------------------------------------
[~ptupitsyn], thank you for the notes!
I've fixed code style notes and have removed unused import.
If you have a minute, please, check it once again. Thanks!
bq. 4) Could not compile Java (mvn clean package)
It's not related to my changes and as I can see the compilation is already
fixed in the master branch by [a
commit|https://github.com/apache/ignite/commit/e4e0a280853b896f32ae3d85545f83faeb7aa680].
> BinaryMarshaller should write ints in "varint" encoding where it makes sense
> ----------------------------------------------------------------------------
>
> Key: IGNITE-5097
> URL: https://issues.apache.org/jira/browse/IGNITE-5097
> Project: Ignite
> Issue Type: Task
> Components: general
> Affects Versions: 2.0
> Reporter: Vladimir Ozerov
> Assignee: Vyacheslav Daradur
> Labels: important, performance
> Fix For: 2.3
>
>
> There are a lot of places in the code where we write integers for some
> special purposes. Quite often their value will be vary small, so that
> applying "varint" format could save a lot of space at the cost of very low
> additional CPU overhead.
> Specifically:
> 1) Array/collection/map lengths
> 2) BigDecimal's (usually will save ~6 bytes)
> 3) Strings
> 4) Enum ordinals
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
