[
https://issues.apache.org/jira/browse/IGNITE-6099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171356#comment-16171356
]
Sergey Kalashnikov commented on IGNITE-6099:
--------------------------------------------
[~isapego], I did a review as well. Here are my comments:
All comments for the file {{connection_info.cpp}}
1. {{strParams[SQL_DBMS_VER] = "03.00";}}
Shouldn't it be the version of Ignite?
2. {{strParams[SQL_IDENTIFIER_QUOTE_CHAR] = "";}}
Should be {{"\""}}.
3. {{intParams[SQL_SCHEMA_USAGE] = SQL_SU_DML_STATEMENTS |
SQL_SU_TABLE_DEFINITION | SQL_SU_PRIVILEGE_DEFINITION;}}
I think {{SQL_SU_INDEX_DEFINITION}} should also be there. At least H2 supports
schema usage in create index.
4. {{intParams[SQL_SQL92_NUMERIC_VALUE_FUNCTIONS] = 0;}}
Why it is empty?
5.{{ intParams[SQL_ALTER_TABLE] = 0;}}
At least {{SQL_AT_ADD_COLUMN_SINGLE}} should be specified. Probably
{{SQL_AT_ADD_CONSTRAINT}} too (not null constraint)
6. {{intParams[SQL_CREATE_TABLE] = SQL_CT_CREATE_TABLE;}}
Probably need to add {{SQL_CT_COLUMN_CONSTRAINT}} (not null).
7. {{intParams[SQL_INSERT_STATEMENT] = SQL_IS_INSERT_LITERALS;}}
{{SQL_IS_INSERT_LITERALS}} represents “INSERT INTO…VALUES…”,
{{SQL_IS_INSERT_SEARCHED}} represents “INSERT INTO…SELECT…FROM…” and
{{SQL_IS_SELECT_INTO}} represents “SELECT…INTO…FROM…”.
So, I think the {{SQL_IS_INSERT_SEARCHED}} should also be included.
> ODBC: Implement SQLGetInfo for all info types
> ---------------------------------------------
>
> Key: IGNITE-6099
> URL: https://issues.apache.org/jira/browse/IGNITE-6099
> Project: Ignite
> Issue Type: Task
> Components: odbc
> Affects Versions: 2.1
> Reporter: Igor Sapego
> Assignee: Igor Sapego
> Labels: usability
> Fix For: 2.3
>
>
> Currently not all the info types supported for {{SQLGetInfo}}. Need to
> implement fully. Details can be found here -
> https://docs.microsoft.com/en-us/sql/odbc/reference/syntax/sqlgetinfo-function
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
