[
https://issues.apache.org/jira/browse/IGNITE-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183959#comment-16183959
]
Alexander Paschenko commented on IGNITE-6286:
---------------------------------------------
Hi [~schernolyas],
Here are my comments that I have fixed myself:
1. Adding a new dependency is almost absolutely always a bad idea, especially
if just for a test. At least in case of Ignite, that is.
2. You haven't added javadocs to all members of all classes, including inner
ones like I asked - please have a look at my patch to see that all members of
all classes now have javadocs: though they are empty, their presence is a must
per Ignite's coding conventions.
3. Reflection usage is clearly an overkill, although overall you've got my
point of code deduplication correctly, thanks. I've removed reflection uses -
please have a look at the patch.
4. There were some double empty lines, I removed them too.
Please apply my patch {{6286.patch}} (attached to this issue above) to your
branch and commit it, thanks! Then please change issue status to "patch
available" for us to know that it's good to be merged.
> org.h2.jdbc.JdbcSQLException: Hexadecimal string with odd number of characters
> ------------------------------------------------------------------------------
>
> Key: IGNITE-6286
> URL: https://issues.apache.org/jira/browse/IGNITE-6286
> Project: Ignite
> Issue Type: Bug
> Components: sql
> Affects Versions: 2.1
> Reporter: Sergey Chernolyas
> Assignee: Sergey Chernolyas
> Labels: usability
> Fix For: 2.3
>
> Attachments: 6286.patch
>
>
> Binding values of some types to parameterized queries leads to the exception
> (see fill stacktrace in comments).
> Also, the exception *blocks* using parameterized queries for Hibernate OGM.
> I proceed the exception for String type. For control it, I developed test (
> see
> org.apache.ignite.internal.processors.query.IgniteSqlParameterizedQueryTest)
> .
> The exception reproduced for BigDecimal type in 2.3-snapshot.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
