[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184246#comment-16184246
]
Ryabov Dmitrii edited comment on IGNITE-602 at 9/28/17 3:02 PM:
----------------------------------------------------------------
Ok, I'll think about test changes on weekend. But I think we don't need
anything like ByteBuffer in return of toString() method. Even
GridNioServer.ByteBufferNioClientWorker, which I annotated, doesn't have this
buffer in it's own toString Implementation. May be add ByteBuffer or Buffer as
exception in GridToStringBuilder (like arrays)? But I'd prefer to place
annotation.
was (Author: somefire):
Ok, I'll think about test changes.
> [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by
> infinite recursion
> --------------------------------------------------------------------------------------------
>
> Key: IGNITE-602
> URL: https://issues.apache.org/jira/browse/IGNITE-602
> Project: Ignite
> Issue Type: Bug
> Components: general
> Reporter: Artem Shutak
> Assignee: Ryabov Dmitrii
> Labels: MakeTeamcityGreenAgain, Muted_test
> Fix For: 2.4
>
>
> See test
> org.gridgain.grid.util.tostring.GridToStringBuilderSelfTest#_testToStringCheckAdvancedRecursionPrevention
> and related TODO in same source file.
> Also take a look at
> http://stackoverflow.com/questions/11300203/most-efficient-way-to-prevent-an-infinite-recursion-in-tostring
> Test should be unmuted on TC after fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
