[
https://issues.apache.org/jira/browse/IGNITE-6554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190026#comment-16190026
]
ASF GitHub Bot commented on IGNITE-6554:
----------------------------------------
GitHub user dspavlov opened a pull request:
https://github.com/apache/ignite/pull/2798
IGNITE-6554: Atomic cache remove operations are logged in WAL as update
records
Probably fix for atomic cache remove operations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-6554
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/2798.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2798
----
commit 73d3aefabcfac2075dda23563437a1018b3444c6
Author: dpavlov <[email protected]>
Date: 2017-10-03T12:26:42Z
IGNITE-6539: Human readable WAL parser fails if empty log files exists in
directory
commit 98b2502e8a8d50aab4b1fc0031e30a279cd6c0cb
Author: dpavlov <[email protected]>
Date: 2017-10-03T16:30:44Z
IGNITE-6553: Standalone WAL iterator fails to handle delete WAL data records
commit 61a0859d570532c7c88d5e007c9bf5733f195898
Author: dpavlov <[email protected]>
Date: 2017-10-03T17:13:10Z
IGNITE-6553: Standalone WAL iterator fails to handle delete WAL data records
commit 73293276beef4619b027a2787638d473671c6bd2
Author: dpavlov <[email protected]>
Date: 2017-10-03T17:34:16Z
IGNITE-6554: Atomic cache remove operations are logged in WAL as update
records
----
> Atomic cache remove operations are logged in WAL as update records
> ------------------------------------------------------------------
>
> Key: IGNITE-6554
> URL: https://issues.apache.org/jira/browse/IGNITE-6554
> Project: Ignite
> Issue Type: Bug
> Components: persistence
> Reporter: Dmitriy Pavlov
> Assignee: Alexey Goncharuk
> Priority: Blocker
> Fix For: 2.3
>
>
> Create cache with atomicity mode CacheAtomicityMode ATOMIC
> and perform put remove for one cache entry
> {noformat}
> for (int i = 0; i < 10; i++) {
> cache.put(i, new Organization(i, "Organization-" + i));
> if (i % 2 == 0)
> cache.put(i, new Organization(i, "Organization-updated-"
> + i));
> if (i % 5 == 0)
> cache.remove(i);
> }
> {noformat}
>
> Actual WAL content loaded by standalone WAL iterator is as follows:
> {noformat}
> [2017-10-03 20:13:38,920][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 0; Value: Organization{key=0,
> name='Organization-0'}
> [2017-10-03 20:13:38,920][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 0; Value: Organization{key=0,
> name='Organization-updated-0'}
> [2017-10-03 20:13:38,920][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 1; Value: Organization{key=1,
> name='Organization-1'}
> [2017-10-03 20:13:38,920][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 2; Value: Organization{key=2,
> name='Organization-2'}
> [2017-10-03 20:13:38,920][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 2; Value: Organization{key=2,
> name='Organization-updated-2'}
> [2017-10-03 20:13:38,921][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 3; Value: Organization{key=3,
> name='Organization-3'}
> [2017-10-03 20:13:38,921][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 4; Value: Organization{key=4,
> name='Organization-4'}
> [2017-10-03 20:13:38,921][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 4; Value: Organization{key=4,
> name='Organization-updated-4'}
> [2017-10-03 20:13:38,921][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 5; Value: Organization{key=5,
> name='Organization-5'}
> [2017-10-03 20:13:38,921][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 6; Value: Organization{key=6,
> name='Organization-6'}
> [2017-10-03 20:13:38,921][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 6; Value: Organization{key=6,
> name='Organization-updated-6'}
> [2017-10-03 20:13:38,921][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 7; Value: Organization{key=7,
> name='Organization-7'}
> [2017-10-03 20:13:38,922][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 8; Value: Organization{key=8,
> name='Organization-8'}
> [2017-10-03 20:13:38,922][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 8; Value: Organization{key=8,
> name='Organization-updated-8'}
> [2017-10-03 20:13:38,922][INFO
> ][test-runner-#1%reader.IgniteWalReaderTest%][root] //Entry operation UPDATE;
> cache Id76454884; under transaction: null; Key: 9; Value: Organization{key=9,
> name='Organization-9'}
> {noformat}
> For TRANSACTIONAL AtomicityMode same test is passing.
> Reproducing test can be found in IgniteWalReaderTest.java in PR 2797
> (IGNITE-6553):
> https://github.com/apache/ignite/pull/2797/files#diff-0f9e5c632b02b68d2e958ddc217d48a1
> testRemoveOperationPresentedForDataEntryForAtomic fails, but
> testRemoveOperationPresentedForDataEntry is passing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
