[
https://issues.apache.org/jira/browse/IGNITE-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194530#comment-16194530
]
Pavel Tupitsyn edited comment on IGNITE-6272 at 10/6/17 12:24 PM:
------------------------------------------------------------------
[~alexey.tank2],
1) Avoid unnecessary {{ToList()}} calls (performance, extra garbage). In this
particular case the performance hit is insignificant, however, let's do it the
right way so that we have a usable {{WriteEnumerable}} method with a
{{writeAction}}.
2) {{DeployAll}} xmldoc is incomplete, please copy all details from Java side.
3) Javadoc says {{If deployment of some of the provided services fails, then
ServiceDeploymentException containing a list of failed services will be
thrown}}. We should provide the same behavior. Please add
{{ServiceDeploymentException.FailedConfigurations}} property. Refer to
{{CachePartialUpdateException.GetFailedKeys}} for an example of exception
details propagation. Make sure to add tests for this case and all other
possible exceptions and corner cases (null args, null collection element, empty
configs, etc).
was (Author: ptupitsyn):
[~alexey.tank2],
1) Avoid unnecessary {{ToList()}} calls (performance, extra garbage). In this
particular case the performance hit is insignificant, however, let's do it the
right way so that we have a usable {{WriteEnumerable}} method with a
{{writeAction}}.
2) {{DeployAll}} xmldoc is incomplete, please copy all details from Java side.
3) Javadoc says {{If deployment of some of the provided services fails, then
{@link ServiceDeploymentException} containing a list of failed services will be
thrown}}. We should provide the same behavior. Please add
{{ServiceDeploymentException.FailedConfigurations}} property. Refer to
{{CachePartialUpdateException.GetFailedKeys}} for an example of exception
details propagation. Make sure to add tests for this case and all other
possible exceptions and corner cases (null args, null collection element, empty
configs, etc).
> .NET: Propagate multiple services deployment
> --------------------------------------------
>
> Key: IGNITE-6272
> URL: https://issues.apache.org/jira/browse/IGNITE-6272
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
> Reporter: Denis Mekhanikov
> Assignee: Alexey Popov
> Labels: .NET, newbie
> Fix For: 2.4
>
>
> Multiple services deployment support should be propagated to .NET:
> * {{IgniteServices.deployAll}}
> * {{IgniteServices.deployAllAsync}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
