[
https://issues.apache.org/jira/browse/IGNITE-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198484#comment-16198484
]
Pavel Tupitsyn commented on IGNITE-6272:
----------------------------------------
[~alexey.tank2], looks good to me in general. Some more comments:
1) Code line length should not exceed 120 characters
(ServiceDeploymentException.cs and some other places)
2) {{FailedConfigurations}} can return null (to be consistent with other places
like {{FailedKeys}})
3) {{FailedConfigurations}} should be serialized (see {{GetObjectData}} and
serialization ctor).
4) Empty methods should contain {{// No-op.}} comment to indicate that they are
empty on purpose ({{public ServiceConfiguration()}}).
5) No need for try-catch is {{ServiceConfiguration}} constructor, since we have
that in {{ReadDeploymentResult}}.
6) {{Services.DeployAll}}: multiple enumeration of {{configurations}}
parameter. This can have unexpected effects in case of lazy iterators.
> .NET: Propagate multiple services deployment
> --------------------------------------------
>
> Key: IGNITE-6272
> URL: https://issues.apache.org/jira/browse/IGNITE-6272
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
> Reporter: Denis Mekhanikov
> Assignee: Alexey Popov
> Labels: .NET, newbie
> Fix For: 2.4
>
>
> Multiple services deployment support should be propagated to .NET:
> * {{IgniteServices.deployAll}}
> * {{IgniteServices.deployAllAsync}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
