[ 
https://issues.apache.org/jira/browse/IGNITE-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212243#comment-16212243
 ] 

ASF GitHub Bot commented on IGNITE-6519:
----------------------------------------

GitHub user akuramshingg opened a pull request:

    https://github.com/apache/ignite/pull/2890

    IGNITE-6519 Race in SplitAwareTopologyValidator on activator and server 
node join

    Using a bigger topology
    TestRecordingCommunicationSpi fix (future timeout instead of 
ClusterTopologyException)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-6519

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2890.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2890
    
----
commit 3255bab8264afea3ee29e0c4ed422feb9aa35302
Author: Alexandr Kuramshin <[email protected]>
Date:   2017-10-20T05:28:56Z

    IGNITE-6519 Race in SplitAwareTopologyValidator on activator and server 
node join
    
    Using a bigger topology
    TestRecordingCommunicationSpi fix (future timeout instead of 
ClusterTopologyException)

----


> Race in SplitAwareTopologyValidator on activator and server node join
> ---------------------------------------------------------------------
>
>                 Key: IGNITE-6519
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6519
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: 2.1
>            Reporter: Alexandr Kuramshin
>            Assignee: Alexandr Kuramshin
>
> The following sequence may occur:
> 1. {{SplitAwareTopologyValidator}} detects split, gets {{NOTVALID}} and 
> returns false from {{validate()}}
> 2. Activator node joins and {{SplitAwareTopologyValidator}} gets {{REPAIRED}}
> 3. Server node joins from other DC and it makes 
> {{SplitAwareTopologyValidator}} gets {{VALID}}
> 4. Then the server node left the cluster and {{SplitAwareTopologyValidator}} 
> should return false from {{validate()}} in cause of next split
> But current implementation makes {{SplitAwareTopologyValidator}} 
> auto-{{REPAIRED}}. Actually if the activator node will being forgotten to 
> leave the cluster it may automatically repair a split many times. But it 
> supposed to be manual operation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to