[
https://issues.apache.org/jira/browse/IGNITE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224770#comment-16224770
]
Vladimir Ozerov commented on IGNITE-6787:
-----------------------------------------
[~gvvinblade], I looked at initial implementation. Here is my comments:
1) {{AbstractNioClientWorker.checkIdle}} - need to replace magic constant with
a static named constant
2) {{GridNioServer.close}} - "Offered close" in log message
3) {{GridNioServer.pauseReads}} - "Offered pause reads" in log message
4) {{GridNioServer.resend}} - need to double-check order of resent futures
5) {{GridNioServer.cancelConnect}} - unused method, is it OK?
6) {{GridNioWorker.idx}} - rename to {{index}}, as abbreviations in method
names are prohibited
7) {{GridSelectorNioSessionImpl.resend}} - unused method
8) {{SessionChangeRequest.prepare}} - all implementations are no-op, let's
remove this method
9) There is code duplication in 3 classes implementing {{SessionWriteRequest}}.
Can we have just one class with future field inside, which is only initialized
when needed? This will simplify implementation greatly.
> Simplifying and optimising GridNioServer
> ----------------------------------------
>
> Key: IGNITE-6787
> URL: https://issues.apache.org/jira/browse/IGNITE-6787
> Project: Ignite
> Issue Type: Improvement
> Security Level: Public(Viewable by anyone)
> Components: general
> Affects Versions: 2.2
> Reporter: Igor Seliverstov
> Assignee: Igor Seliverstov
> Fix For: 2.4
>
>
> Seems we are able to improve communication model using Mpsc queues, NIO task
> abstractions and reducing concurrent operations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
