[ 
https://issues.apache.org/jira/browse/IGNITE-5934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251056#comment-16251056
 ] 

Vladimir Ozerov edited comment on IGNITE-5934 at 11/14/17 9:03 AM:
-------------------------------------------------------------------

MVCC support for queries is mostly ready. However, several things need to be 
addressed:
1) Perform cleanup in {{MvccQueryTracker}}, so that all TODOs has relevant 
tickets.
2) {{GridReduceQueryExecutor.query}} - need to make sure that queries without 
caches (e.g. {{SELECT 1}}) works correctly. This also can be done in separate 
ticket.
3) Check if {{GridH2IndexRangeRequest}} requires MVCC version as well (see 
{{GridH2IndexBase.onIndexRangeRequest}}).
4) {{H2TreeIndex}} - we need to merge {{mvccFilter}} and 
{{IndexingQueryCacheFilter}} into a single implementation of 
{{TreeRowClosure}}. There should be a common method to get this filter from 
thread-local context. Currently we mistakenly ignore 
{{IndexingQueryCacheFilter}} in {{H2TreeIndex.findFirstOrLast}} method. Backup 
closure should be checked first.


was (Author: vozerov):
MVCC support for queries is mostly ready. However, several things need to be 
addressed:
1) Perform cleanup in {{MvccQueryTracker}}, so that all TODOs has relevant 
tickets.
2) {{GridReduceQueryExecutor.query}} - need to make sure that queries without 
caches (e.g. {{SELECT 1}}) works correctly. This also can be done in separate 
ticket.
3) Check if {{GridH2IndexRangeRequest}} requires MVCC version as well (see 
{{GridH2IndexBase.onIndexRangeRequest}}).
4) {{H2TreeIndex}} - we need to merge {{mvccFilter}} and 
{{IndexingQueryCacheFilter}} into a single implementation of 
{{TreeRowClosure}}. There should be a common method to get this filter from 
thread-local context. Currently we mistakenly ignore 
{{IndexingQueryCacheFilter}} in {{H2TreeIndex.findFirstOrLast}} method.

> Integrate mvcc support in sql query protocol
> --------------------------------------------
>
>                 Key: IGNITE-5934
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5934
>             Project: Ignite
>          Issue Type: Task
>          Components: sql
>            Reporter: Semen Boikov
>             Fix For: 2.4
>
>
> Need integrate mvcc support in sql query protocol:
> - request current ID and list of active txs from coordinator
> - pass this info in sql requests and in sql queries
> - notify coordinator after query completed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to