[
https://issues.apache.org/jira/browse/IGNITE-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254974#comment-16254974
]
Alexey Goncharuk commented on IGNITE-6496:
------------------------------------------
I do not think that a silent semaphore release is a good option for client
disconnect. If a client disconnects, the semaphores should throw something
like SemaphoreBrokenException and force a user to re-create the semaphore.
> Client node does not reconnect to server node when the latter is restarted.
> ---------------------------------------------------------------------------
>
> Key: IGNITE-6496
> URL: https://issues.apache.org/jira/browse/IGNITE-6496
> Project: Ignite
> Issue Type: Bug
> Components: data structures
> Affects Versions: 1.9
> Reporter: Vyacheslav Koptilin
> Assignee: Vyacheslav Koptilin
> Attachments: ExampleNodeStartup.java
>
>
> The following scenario may result in deadlock on the client node:
> - start server node and one client
> - client node invokes IgniteQueue#take() method, that requires acquiring
> both GridCacheGateway#readLock and GridCacheQueueAdapter#readSem.
> - client node disconnects from the cluster for some reason (for example,
> server node was stopped)
> in that case, GridCacheQueueAdapter does not release readSem and,
> therefore, GridCacheGateway#readLock is also not released.
> - 'tcp-client-disco-msg-worker' hangs due to unable acquiring
> GridCacheGateway.writeLock
> "tcp-client-disco-msg-worker-#10%datastructures.GridCacheQueueClientReconnect1%"
> #101 prio=5 os_prio=0 tid=0x0000000021634000 nid=0x49a8 waiting on condition
> [0x000000003a61e000]
> java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> parking to wait for <0x000000076fa988f8> (a
> java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)
> at
> java.util.concurrent.locks.ReentrantReadWriteLock$WriteLock.lock(ReentrantReadWriteLock.java:943)
> at
> org.apache.ignite.internal.util.StripedCompositeReadWriteLock$WriteLock.lock0(StripedCompositeReadWriteLock.java:154)
> at
> org.apache.ignite.internal.util.StripedCompositeReadWriteLock$WriteLock.lock(StripedCompositeReadWriteLock.java:123)
> at
> org.apache.ignite.internal.processors.cache.GridCacheGateway.writeLock(GridCacheGateway.java:278)
> at
> org.apache.ignite.internal.IgniteKernal.onDisconnected(IgniteKernal.java:3873)
> at
> org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$4.onDiscovery0(GridDiscoveryManager.java:768)
> at
> org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$4.onDiscovery(GridDiscoveryManager.java:573)
> locked <0x000000076f9f4048> (a java.lang.Object)
> at
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.notifyDiscovery(ClientImpl.java:2415)
> at
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.notifyDiscovery(ClientImpl.java:2394)
> at
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.body(ClientImpl.java:1710)
> at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
