[ 
https://issues.apache.org/jira/browse/IGNITE-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253662#comment-16253662
 ] 

Oleg Ignatenko edited comment on IGNITE-5846 at 11/16/17 11:50 AM:
-------------------------------------------------------------------

reviewed pull request #3030.

{{DistributedRegressionExample}} runs fine and changes done to it look good, in 
particular renaming the {{nobs}} and {{nvars}} variables is appreciated.

All unit tests in ML suite passed on my machine.

Changes made to code in ml module look good, I only noticed few minor formal 
issues worth correcting (provided details of these in [pull request 
comments|https://github.com/apache/ignite/pull/3030#issuecomment-344899648]).

Overall the changes look very good, strongly recommend to merge it.


was (Author: oignatenko):
checking pull request #3030 (in progress). {{DistributedRegressionExample}} 
runs fine and changes done to it look good, in particular renaming the {{nobs}} 
and {{nvars}} variables is appreciated. All unit tests in ML suite passed on my 
machine.

> Add support of distributed matrices for OLS regression.
> -------------------------------------------------------
>
>                 Key: IGNITE-5846
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5846
>             Project: Ignite
>          Issue Type: Improvement
>          Components: ml
>            Reporter: Yury Babak
>            Assignee: Aleksey Zinoviev
>
> Currently OSL regression works only with local matrices.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to