[
https://issues.apache.org/jira/browse/IGNITE-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255223#comment-16255223
]
ASF GitHub Bot commented on IGNITE-6612:
----------------------------------------
GitHub user 1vanan opened a pull request:
https://github.com/apache/ignite/pull/3046
IGNITE-6612: Wrap ack methods in their own class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1vanan/ignite ignite-6612
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/3046.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3046
----
commit 645f7c03d7f4b4e75cebaabb13796b9cf28196a2
Author: Ivan <[email protected]>
Date: 2017-11-08T11:18:28Z
initial refactoring
commit 2a9a031feeb069c80fe5bba4771e12800097bdb8
Author: Ivan <[email protected]>
Date: 2017-11-16T09:09:50Z
tests was added
commit 534cf85f96ffed76250406953b27fb785cac049b
Author: Ivan <[email protected]>
Date: 2017-11-16T09:58:06Z
remove garbage
----
> Wrap ack methods in their own class
> -----------------------------------
>
> Key: IGNITE-6612
> URL: https://issues.apache.org/jira/browse/IGNITE-6612
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: None
> Reporter: Ivan Fedotov
> Assignee: Ivan Fedotov
> Priority: Trivial
> Labels: refactor
> Fix For: 2.4
>
>
> Several methods in IgniteKernal implement similar functions: “ackAsciiLogo”,
> “ackConfigUrl”, “ackDaemon”, “ackOsInfo”, “ackLanguageRuntime”,
> “ackRemoteManagement”, “ackVmArguments”, “ackClassPaths”,
> “ackSystemProperties”, “ackEnviromentVariables”, “ackMemoryConfiguration”,
> “ackCacheConfiguration”, “ackP2PConfiguration”, “ackRebalanceConfiguration”.
> These methods should be placed in separate class “AckVariousInformation” and
> called from the class instance in IgniteKernal.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
