[
https://issues.apache.org/jira/browse/IGNITE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264405#comment-16264405
]
Nikolay Tikhonov edited comment on IGNITE-6949 at 11/23/17 2:34 PM:
--------------------------------------------------------------------
[~zaleslaw],
Thank you for your contribution! I've merged the changes to master.
Anyway, ML module needs to serious review. I've found code style issues and
rude exception handling. For example
{noformat}
org.apache.ignite.ml.util.Utils#copy
...
catch (IOException | ClassNotFoundException e) {
e.printStackTrace();
}
{noformat}
[~chief], could you handle this?
was (Author: ntikhonov):
[~zaleslaw],
Thank you for your contribution! I've merged the changes to master.
Anyway, ML module needs to serious review. I've found code style issues and
rude exception handling. For example
{{noformat}}
org.apache.ignite.ml.util.Utils#copy
...
catch (IOException | ClassNotFoundException e) {
e.printStackTrace();
}
{{noformat}}
[~chief], could you handle this?
> Cleanup OLS code
> ----------------
>
> Key: IGNITE-6949
> URL: https://issues.apache.org/jira/browse/IGNITE-6949
> Project: Ignite
> Issue Type: Bug
> Components: ml
> Reporter: Yury Babak
> Assignee: Aleksey Zinoviev
> Fix For: 2.4
>
>
> We want fix wrong styles like wildcards in imports, unnecessary empty lines,
> missed empty lines and if-else blocks format in OLS related files.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
