[ 
https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274074#comment-16274074
 ] 

Vladimir Ozerov commented on IGNITE-6868:
-----------------------------------------

Last thing is {{reset}} handling. Instead of clearing internal fields 
one-by-one, which is not atomic operation, why couldn't we just re-instantiate 
{{TcpCommunicationSpi#metricsLsnr}}? It would require changing it from from 
{{final}} to {{volatile}}.

As far as {{TcpCommunicationMetricsListener}} class, it appears to be internal 
thing, rather than public API, so we'd better to place it in 
{{org.apache.ignite.internal.managers.communication}} package.

> Implement new JMX metrics for TcpCommunicationSpi monitoring
> ------------------------------------------------------------
>
>                 Key: IGNITE-6868
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6868
>             Project: Ignite
>          Issue Type: New Feature
>            Reporter: Aleksey Plekhanov
>            Assignee: Aleksey Plekhanov
>              Labels: iep-6, jmx
>             Fix For: 2.4
>
>
> These additional metrics should be implemented in TcpCommunicationSpi MBean:
> * Received messages count grouped by message type
> * Received messages count grouped by sender node
> * Sent messages count grouped by message type
> * Sent messages count grouped by receiver node



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to